Simplify ACL request refresh detection (improves #4409) #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohabCodeX
force-pushed
the
fix/improve-aclrequest-detection
branch
from
9f17f56 to
07cb21d
Compare
|
related #4484 |
FileEX
reviewed
Sep 23, 2025
|
|
||
| std::string CalculateACLRequestFingerprint(); | ||
| bool HasACLRequestsChanged(); | ||
| protected: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the complex ACL fingerprinting from PR #4409 with a much simpler and more efficient approach.
Thanks for @ArranTuna for mentioning a proper solution.