Add StringName #4169
Merged
Add StringName #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua based StringName Use FromStringAndHash Comments Enable SharedUtil_Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
CStringNameclass that is intended to optimize the interaction with Lua strings. This is the first PR related to element data optimizations.CStringNamerepresents the idea that already exists in other game engines(FName in UE or StringName in Godot, for example) which in short consists in string caching(or interning). It gives us two benefits: less memory usage and fast operations(such as comparison or hash computation). These two will be intensively used in the next PR entirely dedicated to element data optimizations.The discussion related to this: #3287 (comment)