Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless checks #4077

Conversation

TheNormalnij
Copy link
Member

CWeaponSA has no state when m_interface is nullptr. All these check are useless.

@Dutchman101
Copy link
Member

Dutchman101 commented Mar 6, 2025

@TheNormalnij I already explained you a couple of things in private, including that we added security-related checks.

Weapon and bullet cheats (as well as "player crashers" related to weapons handling) can cause code to execute in unexpected ways, from unexpected places, causing unexpected results and abnormal states. Checks that don't make much sense to people that don't have all details can still be there for a reason, and can also be highly speculative (precautions for the unexpected). Additionally, these checks aren't expensive.

I'd like to repeat, but unfortunately more starkly and as you are public here, in public - that we have a hierarchy in the project, and the final decision is always to project management/team. I hope that you start to understand to have more respect for it. I'd appreciate it if you let it go and not re-open this, or argue further, my explanations to you previously should be enough and they are final.

@Dutchman101 Dutchman101 closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants