-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new functions related to underwater effects #3463
base: master
Are you sure you want to change the base?
Conversation
Great! We can fix #2598 by checking if the underwater effect is on, maybe after this PR merged? |
Currently, |
I think we should be able to check the effect anytime without relying on setCameraUnderwaterEffectEnabled |
resetCameraUnderwaterEffect() should not this also reset darkness too and getCameraUnderwaterEffect() should not also get the darkness level too |
Nice job! |
Good job, but please address the requested changed |
Bump? |
can you fix the build @XJMLN
|
Client functions
setCameraUnderwaterEffectEnabled(bool state)
- Enable or disable the underwater effect. This function does not affect the default diving behavior.setCameraUnderwaterEffectSpeed(float speed, float frequency)
- Change the speed and frequency of the underwater effectsetCameraUnderwaterDarkness(bool state, float maxDarknessDepth)
- Enable or disable the screen getting darker as we dive deeper underwater. We can also set the depth at which the screen goes completely dark.getCameraUnderwaterEffect() -> bool enabled, float speed, float frequency
getCameraUnderwaterDarkness() -> bool enabled, float maxDarknessDepth
resetCameraUnderwaterEffect()
- Reset the underwater effect state, speed and frequency to their default valuesresetCameraUnderwaterDarkness()
- Reset the underwater darkness effect state and maximum darkness depth to their default valuesResolves #1297