Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecs for ed25519 public keys and signatures with different hash types #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add codecs for ed25519 public keys and signatures with different hash types #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions table.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ ipfs-ns, namespace, 0xe3, IPFS path
swarm-ns, namespace, 0xe4, Swarm path
ipns-ns, namespace, 0xe5, IPNS path
ed25519-pub, key, 0xed, Ed25519 public key
ed25519-sig, signature, 0xef, Ed25519 signature
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make ed25519-{pub,sig} mean using Ed25519-SHA2 (since that's what effectively all Ed25519 users use), and then add only ed25519-{pub,sig}-sha3? It seems a bit odd to me to have two codec entries which are ambiguous.

dash-block, ipld, 0xf0, Dash Block
dash-tx, ipld, 0xf1, Dash Tx
swarm-manifest, ipld, 0xfa, Swarm Manifest
Expand Down Expand Up @@ -418,6 +419,10 @@ skein1024-1000, multihash, 0xb3dd,
skein1024-1008, multihash, 0xb3de,
skein1024-1016, multihash, 0xb3df,
skein1024-1024, multihash, 0xb3e0,
ed25519-pub-sha2, key, 0xed13,
ed25519-pub-sha3, key, 0xed14,
ed25519-sig-sha2, signature, 0xef13,
ed25519-sig-sha3, signature, 0xef14,
holochain-adr-v0, holochain, 0x807124, Holochain v0 address + 8 R-S (63 x Base-32)
holochain-adr-v1, holochain, 0x817124, Holochain v1 address + 8 R-S (63 x Base-32)
holochain-key-v0, holochain, 0x947124, Holochain v0 public key + 8 R-S (63 x Base-32)
Expand Down