Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update table (filecoin codecs and multihashes, bitcoin-witness-commitment, bls, ripemd) #62

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 21, 2020

also adds a package.json script for npm run update-table

/cc @lidel @ribasushi multiformats/multihash#129

@rvagg rvagg requested a review from vmx July 21, 2020 04:29
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the script to package.json

@hacdias hacdias merged commit 1744eb6 into master Jul 21, 2020
@hacdias hacdias deleted the rvagg/update-table branch July 21, 2020 10:22
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sidenote: the list of codecs that were missing is bit concerning – see multiformats/multicodec#183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants