Skip to content

[code-infra] Type checking: use --incremental #47204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Janpot wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

[code-infra] Type checking: use --incremental #47204

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fb23568
[code-infra] Add caching for stylelint
Janpot Nov 6, 2025
e72ab5e
try typescript cache
Janpot Nov 6, 2025
bd106a6
Update config.yml
Janpot Nov 6, 2025
16780fb
Update config.yml
Janpot Nov 6, 2025
0f460ab
Update config.yml
Janpot Nov 6, 2025
ec9f00d
Merge branch 'master' into stylelint-cache
Janpot Nov 6, 2025
86bbe86
Update config.yml
Janpot Nov 6, 2025
fa44515
revert styleling cache
Janpot Nov 6, 2025
95e9524
Update config.yml
Janpot Nov 6, 2025
b3dcff7
gitignore
Janpot Nov 6, 2025
909eec4
Update config.yml
Janpot Nov 6, 2025
13c8761
Merge branch 'master' into stylelint-cache
Janpot Nov 7, 2025
9b011ca
Merge branch 'master' into stylelint-cache
Janpot Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,17 @@ jobs:
key: eslint-cache-{{ checksum "pnpm-lock.yaml" }}
paths:
- .eslintcache
- restore_cache:
keys:
- stylelint-cache-{{ checksum "pnpm-lock.yaml" }}
- stylelint-cache-
- run:
name: Stylelint
command: pnpm stylelint
command: pnpm stylelint:ci
- save_cache:
key: stylelint-cache-{{ checksum "pnpm-lock.yaml" }}
paths:
- .stylelintcache
- run:
name: Lint Markdown
command: pnpm markdownlint
Expand Down Expand Up @@ -234,6 +242,10 @@ jobs:
resource_class: 'medium+'
steps:
- checkout
- restore_cache:
keys:
- typescript-cache-v3-{{ checksum "pnpm-lock.yaml" }}
- typescript-cache-v3-
- install_js
- run:
name: Transpile TypeScript demos
Expand All @@ -246,6 +258,30 @@ jobs:
command: pnpm typescript:ci
environment:
NODE_OPTIONS: --max-old-space-size=3072
- save_cache:
key: typescript-cache-v3-{{ checksum "pnpm-lock.yaml" }}
paths:
- docs/scripts/tsconfig.tsbuildinfo
Copy link
Contributor

@brijeshb42 brijeshb42 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this support globs? It'll be better for future proofing.

Copy link
Member Author

@Janpot Janpot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, doesn't support globs unfortunately

Copy link
Member Author

@Janpot Janpot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll experiment a bit with a CLI that can take a glob, and that can move/copy the result into a single folder, with a manifest. Then a second CLI that can take this folder and based on the manifest puts everything back in place.

- docs/tsconfig.tsbuildinfo
- packages-internal/docs-utils/tsconfig.tsbuildinfo
- packages-internal/scripts/tsconfig.typecheck.tsbuildinfo
- packages-internal/test-utils/tsconfig.tsbuildinfo
- packages/api-docs-builder-core/tsconfig.tsbuildinfo
- packages/api-docs-builder/tsconfig.tsbuildinfo
- packages/mui-docs/tsconfig.tsbuildinfo
- packages/mui-icons-material/tsconfig.tsbuildinfo
- packages/mui-joy/tsconfig.tsbuildinfo
- packages/mui-lab/tsconfig.tsbuildinfo
- packages/mui-material-nextjs/tsconfig.tsbuildinfo
- packages/mui-material-pigment-css/tsconfig.tsbuildinfo
- packages/mui-material/tsconfig.tsbuildinfo
- packages/mui-private-theming/tsconfig.tsbuildinfo
- packages/mui-styled-engine-sc/tsconfig.tsbuildinfo
- packages/mui-styled-engine/tsconfig.tsbuildinfo
- packages/mui-stylis-plugin-rtl/tsconfig.tsbuildinfo
- packages/mui-system/tsconfig.tsbuildinfo
- packages/mui-types/tsconfig.tsbuildinfo
- packages/mui-utils/tsconfig.tsbuildinfo
- run:
name: Test module augmentation
command: |
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@
"extract-error-codes": "code-infra extract-error-codes --errorCodesPath docs/public/static/error-codes.json --skip @mui/core-downloads-tracker @mui/envinfo @mui/docs @mui/codemod @mui/icons-material",
"template:screenshot": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" ./docs/scripts/generateTemplateScreenshots",
"eslint": "eslint . --cache --report-unused-disable-directives --ext .js,.ts,.tsx --max-warnings 0",
"eslint:ci": "eslint . --cache --cache-strategy content --report-unused-disable-directives --ext .js,.ts,.tsx --max-warnings 0",
"eslint:ci": "pnpm eslint --cache-strategy content",
"stylelint": "stylelint --reportInvalidScopeDisables --reportNeedlessDisables \"docs/**/*.?(c|m)[jt]s?(x)\" \"docs/**/*.css\" --ignore-path .lintignore",
"stylelint:ci": "pnpm stylelint --cache --cache-strategy content",
"markdownlint": "markdownlint-cli2 \"**/*.md\"",
"valelint": "pnpm vale sync && git ls-files | grep -h \".md$\" | xargs pnpm vale --filter='.Level==\"error\"'",
"prettier": "pretty-quick --ignore-path .lintignore --branch master",
Expand Down Expand Up @@ -72,7 +73,7 @@
"test:unit": "nx run nx_test_unit",
"test:argos": "code-infra argos-push --folder test/regressions/screenshots/chrome",
"typescript": "lerna run --no-bail typescript",
"typescript:ci": "lerna run --concurrency 1 --no-bail typescript",
"typescript:ci": "lerna run --concurrency 1 --no-bail typescript -- --incremental",
"use-react-version": "node ./scripts/useReactVersion.mjs",
"validate-declarations": "tsx scripts/validateTypescriptDeclarations.mts",
"generate-codeowners": "node scripts/generateCodeowners.mjs",
Expand Down
Loading