Support pattern matching #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: #57 So that RE2::MatchData can be used with Ruby's pattern matching (https://docs.ruby-lang.org/en/3.0/syntax/pattern_matching_rdoc.html), implement a deconstruct method that returns only the capturing groups. This enables the following example: case RE2('(\d)(\d)?').match("1") in x, y puts "Matched #{x} #{y}" end
mudge
force-pushed
the
pattern-matching
branch
from
5c9c125 to
da95224
Compare
GitHub: #57 In order to support pattern matching in Ruby, add a deconstruct_keys method to RE2::MatchData that will return all named matches if given nil or a subset of matches if given an array of capturing group names as symbols. To match [Ruby's implementation of this](ruby/ruby#6216) there are a few edge cases: 1. If the number of keys given exceeds the number of named capturing groups, immediately return an empty hash. 2. Each key is added to the hash in turn and the first invalid key will cause the hash to be returned so it is possible to get a partial set of named captures.
mudge
force-pushed
the
pattern-matching
branch
from
da95224 to
efc7f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #57
In order to support pattern matching
RE2::MatchDataobjects, implement:RE2::MatchData#deconstructRE2::MatchData#deconstruct_keys