Expose more of RE2's matching interface #120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #119
Add new options to
RE2::Regexp#match
that expose the underlying capabilities of RE2's Match function:We keep compatibility with the previous API by still accepting a number of submatches as the second argument to match.
With these new options in place, we can now offer a higher-level
RE2::Regexp#full_match
andRE2::Regexp#partial_match
API to match RE2's own. Note we don't actually use the underlyingFullMatchN
orPartialMatchN
functions as we need to useMatch
's behaviour of returning the overall match first before any extracted submatches.The plan is to then heavily promote these two methods over the lower-level
match
.