Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted C++ cleanup #102

Merged
merged 10 commits into from
Sep 18, 2023
Merged

Assorted C++ cleanup #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
de53093
Replace use of "using" with explicit naming
mudge Sep 17, 2023
bfa47f0
Use references to NamedCapturingGroups, not copies
mudge Sep 17, 2023
5539990
Remove redundant Ruby macros
mudge Sep 17, 2023
8ab9060
Parse RE2::Options with a pointer, not a reference
mudge Sep 17, 2023
c9ca252
Make all functions file static and use const VALUE
mudge Sep 17, 2023
e0424f7
Avoid unnecessary strings
mudge Sep 17, 2023
9c7de72
Use size_type, remove unnecessary casts
mudge Sep 17, 2023
c23713a
Remove unused variable
mudge Sep 17, 2023
d0b3962
Re-order header includes
mudge Sep 18, 2023
5c50b73
Initialize variables in their declaration
mudge Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ext/re2/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ def build_extension(static_p = false)

have_library("stdc++")
have_header("stdint.h")
have_func("rb_str_sublen")

if !static_p and !have_library("re2")
abort "You must have re2 installed and specified with --with-re2-dir, please see https://github.com/google/re2/wiki/Install"
Expand Down
Loading