Skip to content

Commit

Permalink
Update gni filegroup when building Skia's codec files (flutter#54588)
Browse files Browse the repository at this point in the history
This was added in https://skia-review.googlesource.com/c/skia/+/890319
and Skia plans to delete the old group.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
kjlubick authored Aug 19, 2024
1 parent 52621de commit e29b552
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions skia/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ skia_component("skia") {
sources += skia_effects_sources
sources += skia_colorfilters_sources
sources += skia_effects_imagefilter_sources
sources += skia_codec_core
sources += skia_codec_shared
sources += skia_codec_decode_bmp
sources += skia_encode_srcs
sources += skia_sksl_core_sources
Expand All @@ -649,8 +649,6 @@ skia_component("skia") {
"$_skia_root/src/android/SkAnimatedImage.cpp",
"$_skia_root/src/codec/SkAndroidCodec.cpp",
"$_skia_root/src/codec/SkAndroidCodecAdapter.cpp",
"$_skia_root/src/codec/SkEncodedInfo.cpp",
"$_skia_root/src/codec/SkParseEncodedOrigin.cpp",
"$_skia_root/src/codec/SkSampledCodec.cpp",
"$_skia_root/src/ports/SkDiscardableMemory_none.cpp",
"$_skia_root/src/ports/SkMemory_malloc.cpp",
Expand Down

0 comments on commit e29b552

Please sign in to comment.