Skip to content

Commit

Permalink
Add SK_USE_LEGACY_BLUR_RASTER staging flag (flutter#54314)
Browse files Browse the repository at this point in the history
Skia's CPU-based blur implementation is inaccurate for sigma < 2, but
the Dart imagefilter test uses a case with sigma = 1.

In https://skia-review.googlesource.com/c/skia/+/885107, the algorithm
is updated to be more accurate when sigma < 2, so the output is more
accurate. In order to roll into flutter, the expected color values in
the tests will need to be updated with the removal of this staging flag.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
lhkbob authored Aug 5, 2024
1 parent 0aac603 commit 9254125
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions skia/flutter_defines.gni
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ flutter_defines = [
"SK_LEGACY_IGNORE_DRAW_VERTICES_BLEND_WITH_NO_SHADER",
"SK_DISABLE_LEGACY_METAL_BACKEND_SURFACE",
"SK_DISABLE_LEGACY_PARAGRAPH_UNICODE",
"SK_USE_LEGACY_BLUR_RASTER",

# Fast low-precision software rendering isn't a priority for Flutter.
"SK_DISABLE_LEGACY_SHADERCONTEXT",
Expand Down

0 comments on commit 9254125

Please sign in to comment.