fix(ClientRequest): MockSocket does not have _handle in passthrough #706
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this could be the underlying cause of mswjs/msw#2405? |
|
Yes.. it might fix this as well. but I'm not sure about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
MockSocketnever actually connects to a server, it does not initialize its_handleproperty. As a result, this push creates a connect listener with every push.@kettanaito Please guide me in the leftovers:
this._handleis private; there is an undocumentedhandleoption in the Socket constructor. How do you think we should handle this?Fixes: nock/nock#2830