aio gets: add -eol and -keep options #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom end-of-line (EOL) delimiters and an option to keep or discard the EOL string in the aio gets command. This enhancement allows reading from streams that use delimiters other than newline characters.
Key changes:
- Added
-eoloption to specify custom end-of-line delimiters - Added
-keepoption to control whether EOL strings are included in results - Updated command signature and parameter validation to support the new options
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| jim-aio.c | Implements the new -eol and -keep options with parameter parsing and custom delimiter searching |
| jim_tcl.txt | Updates documentation to describe the new command options and usage |
| tests/aio.test | Adds comprehensive test cases covering various combinations of the new options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
msteveb
force-pushed
the
aio-gets-eol-keep
branch
from
2e83f9a to
bfd693c
Compare
This can make it easier to read non-newline based protocols with gets, especially in conjunction with timeout. Signed-off-by: Steve Bennett <[email protected]>
Signed-off-by: Steve Bennett <[email protected]>
msteveb
force-pushed
the
aio-gets-eol-keep
branch
from
bfd693c to
7d8b5c9
Compare
|
If there are no comments on this I will merge it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom end-of-line (EOL) delimiters and an option to keep or discard the EOL string in the
aio getscommand.This can be helpful when reading from a stream that uses something other than newline as an end of frame sequence.