Skip to content

Conversation

@msrd0
Copy link
Owner

@msrd0 msrd0 commented Feb 23, 2025

By default, rlottie-sys will keep searching for system-installed rlottie via pkg-config. If not found, it will download samsung's source and compile. Disabling vendor-samsung disables it, enabling vendor-telegram instead downloads telegram's source instead.

I took some inspiration from #56 but chose not to use the cmake crate since I didn't see any value in a poorly documented opinionated glorified wrapper around a binary. If all it did was search for cmake in different install locations and give me a nice api for specifying arguments that would be cool. But unfortunately it sets a bunch of crap without telling you and with no way of opting out. If they fix that and/or someone demonstrates how some obscure operating systems like Windows need that I'd be willing to revisit this decision.

I also added include paths similar to #57 which is now necessary since the vendored source won't be in a default search path.

@github-actions
Copy link

Output of cargo public-api diff latest:
Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
(none)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants