Skip to content

arm64: dts: qcom: msm8916: Pull-up the UART RX pin#387

Closed
samcday wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
samcday:msm8916/6.12.1
Closed

arm64: dts: qcom: msm8916: Pull-up the UART RX pin#387
samcday wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
samcday:msm8916/6.12.1

Conversation

@samcday
Copy link
Copy Markdown

@samcday samcday commented Jan 19, 2025

With UART disconnected, no one is driving the UART RX line. It will be floating, which can end up producing garbage on stdin.

Reliable UART is particularly important in early boot stages, otherwise an autoboot sequence might be interrupted, so bootph-all is also added to the RX pin.

With UART disconnected, no one is driving the UART RX line. It will be
floating, which can end up producing garbage on stdin.

Reliable UART is particularly important in early boot stages, otherwise
an autoboot sequence might be interrupted, so bootph-all is also added
to the RX pin.

Co-developed-by: Sam Day <[email protected]>
Signed-off-by: Sam Day <[email protected]>
Signed-off-by: Stephan Gerhold <[email protected]>
@samcday
Copy link
Copy Markdown
Author

samcday commented Jan 21, 2025

Hmm, maybe this is more appropriate to send upstream to u-boot as a tweak rather than to the kernel? Problem is I don't think this fix could be achieved there without adding a million *-u-boot.dtsi files for every individual msm8916 device :\

@stephan-gh
Copy link
Copy Markdown
Member

We should definitely add the bias-pull-up upstream in Linux, since you could potentially hit the garbage input there as well. I'm not sure yet if the bootph-all is acceptable upstream. It is documented in dtschema as a somewhat generic property (i.e. not entirely specific to U-Boot). But whether this is actually accepted needs to be tried.

@stephan-gh
Copy link
Copy Markdown
Member

(I'm planning to send the patch upstream to Linux, just didn't get to it yet)

@samcday
Copy link
Copy Markdown
Author

samcday commented Jan 26, 2025

But whether this is actually accepted needs to be tried.

I wondered this too, but I noticed there's a few upstream DTs with bootph-all now (and even some mentions of it in commit messages). So ... 🤞

@samcday
Copy link
Copy Markdown
Author

samcday commented Jan 27, 2025

By the way, if you accept this PR here in the meantime, it'll mean that gen-uboot-img, which pulls DTs from this repo (in both CI and the written instructions), will subsequently pick up the fixed DTs.

@stephan-gh
Copy link
Copy Markdown
Member

This should be part of the 6.17 branches now (and even the 6.16 ones actually).

@stephan-gh stephan-gh closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants