arm64: dts: qcom: msm8916: Pull-up the UART RX pin#387
arm64: dts: qcom: msm8916: Pull-up the UART RX pin#387samcday wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
Conversation
With UART disconnected, no one is driving the UART RX line. It will be floating, which can end up producing garbage on stdin. Reliable UART is particularly important in early boot stages, otherwise an autoboot sequence might be interrupted, so bootph-all is also added to the RX pin. Co-developed-by: Sam Day <[email protected]> Signed-off-by: Sam Day <[email protected]> Signed-off-by: Stephan Gerhold <[email protected]>
2f4aec4 to
8599174
Compare
|
Hmm, maybe this is more appropriate to send upstream to u-boot as a tweak rather than to the kernel? Problem is I don't think this fix could be achieved there without adding a million |
|
We should definitely add the bias-pull-up upstream in Linux, since you could potentially hit the garbage input there as well. I'm not sure yet if the |
|
(I'm planning to send the patch upstream to Linux, just didn't get to it yet) |
I wondered this too, but I noticed there's a few upstream DTs with |
|
By the way, if you accept this PR here in the meantime, it'll mean that |
|
This should be part of the 6.17 branches now (and even the 6.16 ones actually). |
With UART disconnected, no one is driving the UART RX line. It will be floating, which can end up producing garbage on stdin.
Reliable UART is particularly important in early boot stages, otherwise an autoboot sequence might be interrupted, so bootph-all is also added to the RX pin.