Skip to content

URL insert on scopes to return e-mail#34

Open
caiojhonny wants to merge 1 commit into
mrzmyr:masterfrom
caiojhonny:master
Open

URL insert on scopes to return e-mail#34
caiojhonny wants to merge 1 commit into
mrzmyr:masterfrom
caiojhonny:master

Conversation

@caiojhonny

Copy link
Copy Markdown

No description provided.

@mrzmyr

mrzmyr commented Aug 11, 2016

Copy link
Copy Markdown
Owner

Can you describe briefly what you've done in this PR and why? 🙌🏼

@caiojhonny

Copy link
Copy Markdown
Author

Sorry, my english is bad

Your module is nice, but does not return the user email

I have added 'https://www.googleapis.com/auth/userinfo.email' on your
scopes at line 41

Now we can get the email

Before:
a.scopes = "https://www.googleapis.com/auth/plus.login";

After:
a.scopes = "https://www.googleapis.com/auth/plus.login
https://www.googleapis.com/auth/userinfo.email";

Thanks man!

Atenciosamente,
Caio Jhonny

2016-08-11 14:10 GMT-03:00 mrzmyr notifications@github.com:

Can you describe briefly what you've done in this PR and why? 🙌🏼


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACpmd8e47_rC2R9VfiLYIpk1SRe4kggDks5qe1eLgaJpZM4JfdCa
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants