-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add depth
to Frame
#3328
base: main
Are you sure you want to change the base?
feat: Add depth
to Frame
#3328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
So glad to see this PR, just what I need. Would love to see this merged |
merge this shit pls. |
Did you even bother to try this PR yourself to confirm everything works as expected? |
I sincerely apologize for my previous comment. The frustration took over my keyboard. Yes, I did test it locally and confirmed it was not working, I successfully fixed the dept locally as I needed it urgently. I’m more than happy to contribute so this can get merged. |
This PR is not yet working as expected because it will stall the video pipeline. So it'll not be merged yet, until that's fixed. But I got lots of other stuff to do rn |
@mrousavy Hi. This is an amazing feature. Would be great if it also allows support for android. Is it possible to integrate ARCore with Raw Depth API or Depth API? Thank you. |
@rologr35 CameraX doesn't support depth data streaming. |
What
TL;DR: Adds
Frame.depth
, a nullableCMSampleBuffer
that holds depth data.If
enableDepthData
is true (a prop passed to<Camera>
), the Camera will be configured to set up a depth data output pipeline in addition to the video data output pipeline.Ontop of that, a synchronizer output is created to sync depth data and video data buffers together for timestamps.
Changes
Tested on
Related issues