Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add depth to Frame #3328

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

feat: Add depth to Frame #3328

wants to merge 17 commits into from

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Dec 11, 2024

What

TL;DR: Adds Frame.depth, a nullable CMSampleBuffer that holds depth data.

If enableDepthData is true (a prop passed to <Camera>), the Camera will be configured to set up a depth data output pipeline in addition to the video data output pipeline.
Ontop of that, a synchronizer output is created to sync depth data and video data buffers together for timestamps.

const device = Camera.getAvailableCameraDevices().find((d) => d.formats.some((f) => f.supportsDepthCapture))
const format = useCameraFormat(device, [{ depth: true }])

const fp = useFrameProcessor((frame) => {
  'worklet'
  console.log(frame.depth)
})

if (device == null) throw new Error(`Device does not support depth data!`)
return (
  <Camera
    device={device}
    format={format}
    enableDepthData={true}
    video={true}
    frameProcessor={fp}
  />
)

Changes

Tested on

Related issues

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:08pm

@zigapk
Copy link

zigapk commented Jan 7, 2025

So glad to see this PR, just what I need. Would love to see this merged

@ruca8
Copy link

ruca8 commented Feb 1, 2025

merge this shit pls.

@mrousavy
Copy link
Owner Author

mrousavy commented Feb 3, 2025

merge this shit pls.

Did you even bother to try this PR yourself to confirm everything works as expected?

@ruisg
Copy link

ruisg commented Feb 3, 2025

merge this shit pls.

Did you even bother to try this PR yourself to confirm everything works as expected?

I sincerely apologize for my previous comment. The frustration took over my keyboard.

Yes, I did test it locally and confirmed it was not working, I successfully fixed the dept locally as I needed it urgently. I’m more than happy to contribute so this can get merged.

@mrousavy
Copy link
Owner Author

mrousavy commented Feb 3, 2025

This PR is not yet working as expected because it will stall the video pipeline. So it'll not be merged yet, until that's fixed. But I got lots of other stuff to do rn

@rologr35
Copy link

rologr35 commented Mar 9, 2025

@mrousavy Hi. This is an amazing feature. Would be great if it also allows support for android. Is it possible to integrate ARCore with Raw Depth API or Depth API? Thank you.

@mrousavy
Copy link
Owner Author

@rologr35 CameraX doesn't support depth data streaming.
And any code I'd write in manual Camera2 bridging code would be a workaround, I don't want to release that stuff to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants