Skip to content

Commit

Permalink
fix: Revert lazy audio initialization
Browse files Browse the repository at this point in the history
  • Loading branch information
mrousavy committed Nov 21, 2023
1 parent 6235a77 commit 6bf620d
Showing 1 changed file with 17 additions and 19 deletions.
36 changes: 17 additions & 19 deletions package/ios/Core/CameraSession+Video.swift
Original file line number Diff line number Diff line change
Expand Up @@ -107,25 +107,6 @@ extension CameraSession {
}
self.recordingSession = recordingSession

// Init Audio + Activate Audio Session (optional)
if enableAudio {
if let audioOutput = self.audioOutput {
ReactLogger.log(level: .trace, message: "Enabling Audio for Recording...")
// Activate Audio Session asynchronously
CameraQueues.audioQueue.async {
do {
// Initialize audio asset writer
let audioSettings = audioOutput.recommendedAudioSettingsForAssetWriter(writingTo: options.fileType)
recordingSession.initializeAudioWriter(withSettings: audioSettings)

try self.activateAudioSession()
} catch {
self.onConfigureError(error)
}
}
}
}

// Init Video
guard var videoSettings = self.recommendedVideoSettings(videoOutput: videoOutput,
fileType: options.fileType,
Expand All @@ -150,6 +131,23 @@ extension CameraSession {
recordingSession.initializeVideoWriter(withSettings: videoSettings,
pixelFormat: pixelFormat)

// Init Audio + Activate Audio Session (optional)
if enableAudio, let audioOutput = self.audioOutput {
ReactLogger.log(level: .trace, message: "Enabling Audio for Recording...")
// Activate Audio Session asynchronously
CameraQueues.audioQueue.async {
do {
// Initialize audio asset writer
let audioSettings = audioOutput.recommendedAudioSettingsForAssetWriter(writingTo: options.fileType)
recordingSession.initializeAudioWriter(withSettings: audioSettings)

try self.activateAudioSession()
} catch {
self.onConfigureError(error)
}
}
}

// start recording session with or without audio.
do {
try recordingSession.startAssetWriter()
Expand Down

0 comments on commit 6bf620d

Please sign in to comment.