Add support for MCP23017 (I2C GPIO expander). #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdunk
reviewed
Oct 7, 2025
| int i2c = gpio_i2c_mcp_alloc(address); | ||
| if (i2c >= 0) { | ||
| i2c_gpio_set_pin_config(&i2c_gpio, i2c, index, gpio_type); | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| } | |
| } else { | |
| printf("Error ..."); | |
| } |
mrdunk
reviewed
Oct 7, 2025
src/rp2040/gpio.c
Outdated
| //uint32_t gpio_i2c_mcp_indexes[MAX_I2C_MCP] = {0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff}; | ||
| uint32_t gpio_i2c_mcp_indexes[MAX_I2C_MCP] = {0, 0, 0, 0}; | ||
| uint8_t gpio_i2c_mcp_addresses[MAX_I2C_MCP] = {0xff, 0xff, 0xff, 0xff}; | ||
| uint8_t gpio_last_type[32 * MAX_I2C_MCP]; |
Owner
There was a problem hiding this comment.
i see this being set but never used.
mrdunk
reviewed
Oct 7, 2025
|
|
||
|
|
||
| //uint32_t gpio_i2c_mcp_indexes[MAX_I2C_MCP] = {0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff}; | ||
| uint32_t gpio_i2c_mcp_indexes[MAX_I2C_MCP] = {0, 0, 0, 0}; |
Owner
There was a problem hiding this comment.
gpio_i2c_mcp_indexes not used any more.
Collaborator
Author
There was a problem hiding this comment.
It is used, by gpio_i2c_mcp_alloc.
mrdunk
reviewed
Oct 7, 2025
Owner
mrdunk
left a comment
mrdunk
left a comment
There was a problem hiding this comment.
i left a couple of minor comments.
but LGTM.
you are more familiar with this code than me at the moment so feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the MCP23017 GPIO expander - I2C connected, 14 GPIO pins with optional pullup, 2 GPO pins (7 and 15, a silicon bug makes those pins unreliable as inputs).
The ports are polled while waiting for the packet and after updating the motion values. However, this normally shouldn't be the problem, because the polling code is guaranteed to finish quickly, except for the printf after a communication error.