WebXRManager: Further improvements to WebXR layers feature testing. (#…

…30282) * Further improvements to WebXR layers feature testing * Update webxr_vr_layers.html Clean up. * Update WebXRManager.js Clean up. * Updated E2E screenshot. --------- Co-authored-by: Michael Herzog <[email protected]>
mrdoob · Jan 10, 2025 · e648b56 · e648b56
1 parent 5fb35c7
commit e648b56
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/examples/screenshots/webxr_vr_layers.jpg b/examples/screenshots/webxr_vr_layers.jpg
diff --git a/examples/webxr_vr_layers.html b/examples/webxr_vr_layers.html
@@ -305,9 +305,12 @@
 				const gl = renderer.getContext();
 
 				// Init layers once in immersive mode and video is ready.
-				const useLayers = session.enabledFeatures !== undefined && session.enabledFeatures.includes('layers');
+				const useLayers = session &&
+					session.enabledFeatures !== undefined &&
+					session.enabledFeatures.includes('layers') &&
+					XRMediaBinding !== undefined;
 
-				if ( session && ! useLayers ) {
+				if ( ! useLayers ) {
 
 					errorMesh.visible = true;
 

diff --git a/src/renderers/webxr/WebXRManager.js b/src/renderers/webxr/WebXRManager.js
@@ -275,7 +275,9 @@ class WebXRManager extends EventDispatcher {
 				currentPixelRatio = renderer.getPixelRatio();
 				renderer.getSize( currentSize );
 
-				const useLayers = session.enabledFeatures !== undefined && session.enabledFeatures.includes( 'layers' );
+				// Check that the browser implements the necessary APIs to use an
+				// XRProjectionLayer rather than an XRWebGLLayer
+				const useLayers = XRWebGLBinding !== undefined && 'createProjectionLayer' in XRWebGLBinding.prototype;
 
 				if ( ! useLayers ) {