Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All features 202403 #14

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

russHyde
Copy link
Contributor

@russHyde russHyde commented Mar 15, 2024

This branch contains updates to the tfpbrowser app as generated during jumpingrivers work during 2024.

Changeset:

  • We bumped the github actions for R-package checks and linting (because the original workflows were failing, and had been superceded at r-libs/actions/)
  • We defined a new environment for the app to run in; this uses Bioconductor 3.16 (since app development / deployment runs on R4.2)
  • We defined a script for creating tfpscanner datasets that are compatible with the environment that the app runs in
  • a workflow for deploying the app along with newly-created tfpscanner datasets has been added as a vignette;
  • Then some stylistic changes were introduced to ensure the package passed the linting workflow (some new indentation linters have been added to the defaults since this workflow last ran)
  • scatterplots have been resized so that they aren't as tall as the treeviews when presented in the app
  • text for an "about" page has been added
  • a sidebar containing the treeview options has been added, the sidebar is collapsible, and is 'sticky' on widescreens
  • the 'mutation' and 'sequence' drop-downs are now hidden when not in use

@russHyde russHyde marked this pull request as draft March 15, 2024 14:47
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 648e3e6 to 165453f Compare March 18, 2024 11:17
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 165453f to 32861c2 Compare March 21, 2024 10:52
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 32861c2 to bc8a91e Compare March 21, 2024 11:30
@russHyde russHyde force-pushed the draft-all-features-202403 branch from bc8a91e to bf878fc Compare March 21, 2024 11:40
@russHyde russHyde force-pushed the draft-all-features-202403 branch from bf878fc to 2a31476 Compare April 16, 2024 10:04
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 742b826 to 36c5103 Compare September 12, 2024 08:52
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 12882a7 to 10ba67c Compare September 12, 2024 09:08
@russHyde russHyde force-pushed the draft-all-features-202403 branch from 10ba67c to abeb9b2 Compare September 12, 2024 09:11
@russHyde russHyde marked this pull request as ready for review September 18, 2024 08:44
@russHyde russHyde force-pushed the draft-all-features-202403 branch from abeb9b2 to 3bd7e61 Compare October 15, 2024 13:58
@russHyde
Copy link
Contributor Author

russHyde commented Nov 8, 2024

@KieranODrake could you check if the latest commit fixes the issue you have had when there are thousands of sequences/mutations to choose from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants