Refactor scripting components and add Portainer deployment workflow#17
Refactor scripting components and add Portainer deployment workflow#17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public void compileShouldWrapGroovyErrors() { | ||
| expectedException.expect(ScriptCompilationException.class); | ||
| expectedException.expectMessage(is("Unable to compile script")); | ||
| expectedException.expectMessage(containsString("badMethod")); |
There was a problem hiding this comment.
Fix impossible ScriptCompiler error expectations
compileShouldWrapGroovyErrors asks the exception message to both equal "Unable to compile script" and also contain "badMethod". A string cannot satisfy both matchers at once, so this test will fail every run even if the compiler correctly wraps Groovy errors, breaking the suite. Align the expected message (or the thrown text) so the matchers are consistent.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task