Update get_pip_version function to check for pip3#4
Open
pdufour wants to merge 2 commits into
Open
Conversation
mprpic
reviewed
May 12, 2026
|
|
||
| cat >> "$PROFILE_SCRIPT" << SHELL | ||
| # cooldowns:pip:start | ||
| pip() { |
Owner
There was a problem hiding this comment.
I think the name of the wrapper itself needs to be modified here, otherwise if users are executing pip3 then this will never trigger the wrapper.
| local tool="$1" | ||
| command -v "$tool" &>/dev/null && return 0 | ||
| find_in_profiles "cooldowns:${tool}:start" &>/dev/null && return 0 | ||
| case "$tool" in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When I install python via homebrew, it doesnt install a
pipcommand, it only installs apip3command:This makes it so the pip check in cooldowns checks for the pip3 as well as the pip command.
Test Plan
Run set cmd