fix: Message Compaction System - Critical Bug Fixes #146
+333
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/compact ## Motivation Previously the delayed compaction flag was implemented as a global module-level variable which caused cross-agent contamination and intermittent compaction behavior across sessions. This commit fixes that regression by making the flag instance-scoped and ensuring manual compaction commands properly clear the flag so delayed compaction doesn't trigger unexpectedly. ## Architecture / Approach Remove the global _delayed_compaction_requested and add self._delayed_compaction_requested on BaseAgent instances during initialization. Update request_delayed_compaction() to set the instance flag and should_attempt_delayed_compaction() to consult and reset the instance flag only when it is safe to compact. Align the internal message-processing path to call summarize_messages(...) where logical summarization is expected. Update handle_compact_command (session_commands) to clear the instance flag when a manual /compact succeeds and emit explicit informational/success messages to surface the state change to users. ## Affected Components - code_puppy/agents/base_agent.py: remove global flag; BaseAgent.__init__ adds instance flag; request_delayed_compaction and should_attempt_delayed_compaction now use the instance field; message processing uses summarize_messages call in the compaction flow. - code_puppy/command_line/session_commands.py: handle_compact_command resets the agent._delayed_compaction_requested flag and emits token_context_status messages around manual compaction. - tests/agents/test_base_agent_compaction_flags.py: new comprehensive regression tests for instance-level flag lifecycle and idempotency across agents. - tests/test_command_handler.py: added tests to ensure /compact clears the delayed flag and remains idempotent when the flag is already clear. ## Performance / Security Impact This change is behavioral and has negligible performance impact. It reduces the risk of unintended compaction operations across agent instances (a correctness/security concern for session isolation). The summarize_messages call substitution may centralize compaction behavior but does not change message retention policies beyond fixing the flag semantics. ## Compatibility / Testing Adds unit tests covering initialization, multiple request cycles, pending-tool-call behavior, cross-instance isolation, and manual /compact interactions to prevent regressions. The change is backward compatible from a user perspective; manual /compact now explicitly clears any pending delayed compaction flag (preventing duplicate compactions). Developers should note the removed global flag if any external code referenced it.
diegonix
force-pushed
the
hotfix/compaction_sched
branch
from
611e2af to
16dd7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Message Compaction System - Critical Bug Fixes
Problem
The message compaction system had two critical bugs:
Missing method:
PlanningAgent object has no attribute 'compact_messages'- The code calledself.compact_messages()which doesn't exist; it should beself.summarize_messages()Global flag state leak: The
_delayed_compaction_requestedflag was a global variable that could leak state between sessions. Additionally, the flag was never reset when/compactwas executed manually, causing spurious delayed compaction attempts on subsequent messages.Solution
Fixed method call in
base_agent.py:1796- Changedself.compact_messages()toself.summarize_messages()Refactored global flag to instance attribute in
base_agent.py:93- Moved_delayed_compaction_requestedfrom module-level global to instance variableself._delayed_compaction_requestedto prevent state contamination between sessionsAdded flag reset in
/compactcommand insession_commands.py- Addedagent._delayed_compaction_requested = Falseto reset the flag after manual compactionAdded comprehensive test coverage - Created
tests/agents/test_base_agent_compaction_flags.pywith 9 unit tests covering flag lifecycle, idempotency, and instance isolationFiles Changed
code_puppy/agents/base_agent.py- Flag refactor + method fixcode_puppy/command_line/session_commands.py- Flag reset in/compacttests/agents/test_base_agent_compaction_flags.py- New test file (9 tests)Testing
Backwards Compatibility