fix: resolve clippy errors in tree-sitter comparison test#15
Merged
Conversation
Fix all clippy violations in tests/compare_tree_sitter.rs: - Replace unwrap() with Result return and let-else pattern - Split compare_parsers (97 lines) under 60-line limit via GrandTotals struct - Replace redundant closure with Result::ok method reference - Isolate usize-to-f64 casts in pct() with cast_precision_loss allow - Mark GrandTotals::new() and add() as const fn Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/compare_tree_sitter.rs:unwrap_used, function too long, redundant closure,cast_precision_loss, andconst fnsuggestionsTest plan
justpasses (fmt + clippy + tests)just compare-tree-sitterruns successfully🤖 Generated with Claude Code