Qr code download link proposal

[oliver-dvorski]

In hopes of bumping #423 a bit, I figured why not try to implement that feature myself.

Since I have no idea what I'm doing and since I've never heard of Choo before diving into this, I tried oversimplifying the whole thing and coupled a QR code view to the copy to clipboard action. This is what that looks like:

Any thoughts? I'm expecting to trigger everyone with the way I wrote this so don't hold back, just let it out

Sorry for the broken gif, it's late and I want to go home 😄

[dannycoates]

Nice start @oliver-dvorski! We'll want to tweak the ui some, but this is great. I'll be able to give you more feedback next week.

[oliver-dvorski]

@dannycoates Awesome 😊
Can't wait to refine this

[cmpadden]

Hi @oliver-dvorski, while I don't have any feedback on this pull request I wanted to say thank you for your proposal.

I often find myself wishing that the Firefox Send URLs were either shorter or had an easy way to copy them to other devices -- this would be great! Thanks!

[oliver-dvorski]

@cmpadden Thanks! That means a lot. I too can't wait to get this rolling so I can finally kill makeazip.com 😄 and let the big boys provide a much better service than I ever could

[cjbarth]

This is also super useful for sending stuff from Android to iOS, like photos. What else is needed to get this landed?

[fzzzy]

The only thing required for this to land is for someone to have time to review it. There's nobody full time on send right now. I might be able to take a look at it next week.

[cjbarth]

@oliver-dvorski It would be nice if there were no merge conflicts when this does get reviewed, hopefully next week. Would you be in a position to fix this merge conflict?

[oliver-dvorski]

Should be doable. Tomorrow I'll be heading back from vacation so I should have that fixed soon Chris Barth <[email protected]> schrieb am Mo., 7. Okt. 2019, 19:51:

…

@oliver-dvorski <https://github.com/oliver-dvorski> It would be nice if there were no merge conflicts when this does get reviewed, hopefully next week. Would you be in a position to fix this merge conflict? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1328?email_source=notifications&email_token=ACE6RYITHXJOKF3BSL4LGJTQNNZJRA5CNFSM4HLLX2H2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARHGLA#issuecomment-539128620>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACE6RYJIRW2VOGKY5VB7453QNNZJRANCNFSM4HLLX2HQ> .

[oliver-dvorski]

Alrighty, I think I got myself out of that git mess I made. Should be squeaky clean now

[cjbarth]

It looks like @dannycoates updated dependencies in this project and messed up the lock file again :( Maybe just leave the lock file out of this PR and let the maintainers add the lock for the dependencies that you need when they do their regular package updates?

[oliver-dvorski]

@cjbarth Brilliant Idea! Unfortunately, the test pipeline is checking to see if the two files are in sync and when they're not - it throws an error. So I thought I'll just update the thing instead and just push whenever. Which is still cool, because now that I rebased on master, I see that there's a test that's failing so I can address that