Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
+ Coverage 78.54% 78.55% +0.01%
==========================================
Files 74 74
Lines 44039 44056 +17
==========================================
+ Hits 34591 34609 +18
+ Misses 9448 9447 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Oct 27, 2026
| take_arg!("-fthin-link-bitcode", OsString, Concatenated(b'='), TooHard), | ||
| take_arg!("-ftime-trace", OsString, Concatenated(b'='), TooHard), | ||
| // The trace is a side file that doesn't affect the object; a cache hit just produces no trace. | ||
| take_arg!("-ftime-trace", OsString, Concatenated(b'='), PassThrough), |
Collaborator
There was a problem hiding this comment.
nvcc's -fdevice-time-trace is still TooHard, same reasoning applies, no?
could be done in a follow-up
sylvestre
reviewed
Oct 27, 2026
| for flag in [ | ||
| "-ftime-trace", | ||
| "-ftime-trace=trace.json", | ||
| "-ftime-trace-granularity=50", |
Collaborator
There was a problem hiding this comment.
these two weren't impacted by #2834, were they? fine to keep them, just checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v0.18.0 (PR #2834) any compile with
-ftime-tracecan't be cached. The trace doesn't affect the object, so this goes back to the v0.17.0 behavior: hash and pass the flag through, and produce no trace on a cache hit.Reference: ClickHouse/ClickHouse#127827