Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
ignore_time_macrosoff, a header containing__DATE__or__TIMESTAMP__is never compared by content on lookup, so a same-size edit to it is served the old object:result_matchesskips the digest check once a time macro is found. The input file's__TIMESTAMP__is not in the entry key either.Now every file is remembered, checked and keyed by its content digest plus the date for
__DATE__and its mtime for__TIMESTAMP__. Files with neither keep their plain digest, so existing entries stay valid. Lookups no longer rewrite entries.#2741 reseeds the time-macro digest and #2940 caches it; both keep the skip and serve these edits stale.
Three new tests fail with the fix undone and pass with it.