Repository navigation
Look up true on PATH in the symlinked libdir test - #2926
Merged
Merged
Conversation
The test copied /bin/true to use as a stand-in rustc binary, but that path does not exist on NixOS, which only provides /bin/sh. Resolve the binary through PATH with the `which` crate instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
=======================================
Coverage 78.13% 78.13%
=======================================
Files 74 74
Lines 43570 43571 +1
=======================================
+ Hits 34043 34044 +1
Misses 9527 9527 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for your PR |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test copied /bin/true to use as a stand-in rustc binary, but that path does not exist on NixOS, which only provides /bin/sh. Resolve the binary through PATH with the
whichcrate instead.