Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
+ Coverage 78.06% 78.19% +0.13%
==========================================
Files 73 74 +1
Lines 43233 43396 +163
==========================================
+ Hits 33749 33933 +184
+ Misses 9484 9463 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
codeandsolder-git-wrangler
Bot
force-pushed
the
upstream-pr/client-side-multilevel-stats
branch
from
October 18, 2026 09:10
5512028 to
e65dd2f
Compare
sylvestre
reviewed
Oct 18, 2026
| for level in &self.levels { | ||
| for (idx, level) in self.levels.iter().enumerate() { | ||
| let start = Instant::now(); | ||
| if let Some(bytes) = level.get_raw(key).await? { |
Collaborator
There was a problem hiding this comment.
with ? an error on L0 returns early and records nothing, while get() counts it as a miss and tries the next level. is that intended?
Collaborator
|
Thanks for your PR |
1 task done
codeandsolder-git-wrangler
Bot
deleted the
upstream-pr/client-side-multilevel-stats
branch
October 26, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2804.
Summary
Validation
cargo fmtandgit diff --check