Repository navigation
test: return target-libdir in rustc cache-miss mock - #2885
Merged
Merged
Conversation
Compiler detection requests both sysroot and target-libdir. Return both lines so the daemon and client-side rmeta notification tests reach compilation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
===========================================
+ Coverage 27.87% 77.57% +49.70%
===========================================
Files 71 72 +1
Lines 38079 41409 +3330
===========================================
+ Hits 10614 32124 +21510
+ Misses 27465 9285 -18180 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weihanglo
marked this pull request as ready for review
October 7, 2026 14:44
Collaborator
|
Thanks for your PR |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2852 changed how the compiler detection works. Now it requests both sysroot and target-libdir. We need to adjust the mock rustc accordingly.
This should fix the CI failure in https://github.com/mozilla/sccache/actions/runs/37596909346/job/112711671349.
Expand to see failures
🤖 LLM disclosure: code change was fully generated by LLM.