Skip to content

Support -Xclang -fobjc-dispatch-method flag for caching - #2696

Open
nunoleitao-ops wants to merge 9 commits into
mozilla:mainfrom
nunoleitao-ops:support-xclang-fobjc-dispatch-method
Open

nunoleitao-ops wants to merge 9 commits into
mozilla:mainfrom
nunoleitao-ops:support-xclang-fobjc-dispatch-method

Conversation

@nunoleitao-ops

Copy link
Copy Markdown

Add -fobjc-dispatch-method to the clang ARGS table so that compilation units passing -Xclang -fobjc-dispatch-method=<value> (used by ObjC/GNUstep builds) are cached rather than falling back to direct compiler invocation.

Add `-fobjc-dispatch-method` to the clang ARGS table so that compilation
units passing `-Xclang -fobjc-dispatch-method=<value>` (used by ObjC/GNUstep
builds) are cached rather than falling back to direct compiler invocation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented May 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (54b6f72) to head (4a25355).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2696   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files          72       72           
  Lines       40805    40817   +12     
=======================================
+ Hits        31319    31330   +11     
- Misses       9486     9487    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 10.8%

1 warning

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 56 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation time_macro_finder_chunked 862.8 µs 1,026.3 µs -15.93%
❌ CPU Simulation time_macro_finder_no_macros 2.9 ms 3 ms -5.36%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nunoleitao-ops:support-xclang-fobjc-dispatch-method (4a25355) with main (54b6f72)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants