chore: switch thirtyfour_sync to thirtyfour by tottoto · Pull Request #2613 · mozilla/sccache

tottoto · 2026-02-12T11:40:45Z

Switches unmaintained thirtyfour_sync to thirtyfour.

codecov-commenter · 2026-02-12T11:44:42Z

Codecov Report

❌ Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (146f4df) to head (052a22b).

Files with missing lines	Patch %	Lines
tests/oauth.rs	0.00%	41 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
+ Coverage   72.82%   73.27%   +0.45%     
==========================================
  Files          68       68              
  Lines       37114    36907     -207     
==========================================
+ Hits        27029    27045      +16     
+ Misses      10085     9862     -223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sylvestre · 2026-02-21T14:45:01Z

Please update the commit to document the why

thirtyfour_sync crate is not maintained.

sylvestre · 2026-02-22T15:03:50Z

            return Some(res);
        } else {
-            thread::sleep(interval);
+            std::thread::sleep(interval);


why this change ? seems unrelated

Since this is now the only place where std::thread is used, importing it solely for this felt unnecessary.

please avoid unrelated changes :)

Do you think this is not related?

I proposed including it in this pull request because it arose as a result of this change, and I thought it would be appropriate to include it.

….0) (#40) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [mozilla/sccache](https://github.com/mozilla/sccache) | minor | `0.14.0` → `0.15.0` | --- ### Release Notes <details> <summary>mozilla/sccache (mozilla/sccache)</summary> ### [`v0.15.0`](https://github.com/mozilla/sccache/releases/tag/v0.15.0) [Compare Source](mozilla/sccache@v0.14.0...v0.15.0) ##### sccache 0.15.0 ##### Summary sccache 0.15.0 brings several notable improvements: - **Multi-tier caching**: New support for layered caches with fallback and automatic backfilling between tiers ([#2581](mozilla/sccache#2581)). - **C++20 modules**: Initial (partial) support for compiling C++20 modules ([#2516](mozilla/sccache#2516)). - **Expanded MSVC support**: New flags handled including `d1nodatetime`, `await:strict` ([#2617](mozilla/sccache#2617)), `Y-`, `YI`, `Zf` ([#2663](mozilla/sccache#2663)), and the default `.pdb` extension for `/Fd` ([#2621](mozilla/sccache#2621)). - **New platforms**: loongarch64 support ([#2669](mozilla/sccache#2669)) and `crt-static` for riscv64 musl targets ([#2683](mozilla/sccache#2683)). - **ccache interop**: Avoid double-caching when ccache is also installed in `PATH` ([#2524](mozilla/sccache#2524)). - **Cargo integration**: `CARGO_ENCODED_RUSTFLAGS` is now excluded from the env var hash to prevent spurious cache misses ([#2651](mozilla/sccache#2651)), and dep-info handling correctly skips directories ([#2676](mozilla/sccache#2676)). - **Distribution**: cargo-binstall metadata for prebuilt binary installation ([#2647](mozilla/sccache#2647)). - **Reliability fixes**: GCS initialization ([#2637](mozilla/sccache#2637)), Windows `Win32_Security` feature ([#2627](mozilla/sccache#2627)), and retries for dist docker image builds ([#2677](mozilla/sccache#2677)). This release also includes a large round of clippy-driven cleanups and several CI fixes. Welcome to 7 new contributors! ##### Features - Avoid double-caching when ccache is installed in PATH by [@avikivity](https://github.com/avikivity) in [#2524](mozilla/sccache#2524) - partial c++20 module support by [@TroyKomodo](https://github.com/TroyKomodo) in [#2516](mozilla/sccache#2516) - Add support for `d1nodatetime` & `await:strict` MSVC flags by [@AJIOB](https://github.com/AJIOB) in [#2617](mozilla/sccache#2617) - msvc: Append the default .pdb extension for the /Fd argument by [@ikolomiko](https://github.com/ikolomiko) in [#2621](mozilla/sccache#2621) - msvc: add support for Y-, YI, Zf flags by [@AJIOB](https://github.com/AJIOB) in [#2663](mozilla/sccache#2663) - Implement multiple tiers caching with fallback and backfilling by [@Felixoid](https://github.com/Felixoid) in [#2581](mozilla/sccache#2581) - feat: Add loongarch64 support by [@wojiushixiaobai](https://github.com/wojiushixiaobai) in [#2669](mozilla/sccache#2669) - Add cargo-binstall metadata for prebuilt binary installation by [@sylvestre](https://github.com/sylvestre) in [#2647](mozilla/sccache#2647) ##### Fixes - fix: add Win32\_Security feature to windows-sys dependency by [@JulienCote](https://github.com/JulienCote) in [#2627](mozilla/sccache#2627) - Fix GCS initialization by [@msuozzo](https://github.com/msuozzo) in [#2637](mozilla/sccache#2637) - fix: exclude `CARGO_ENCODED_RUSTFLAGS` from env var hash by [@weihanglo](https://github.com/weihanglo) in [#2651](mozilla/sccache#2651) - fix: handle directories in dep-info source file hashing by [@mmastrac](https://github.com/mmastrac) in [#2676](mozilla/sccache#2676) ##### CI - Revert "actions: add security audit workflow" by [@sylvestre](https://github.com/sylvestre) in [#2603](mozilla/sccache#2603) - ci: fix artifact\_failure action when target dir does not exist by [@sylvestre](https://github.com/sylvestre) in [#2635](mozilla/sccache#2635) - ci: set crt-static for riscv64 musl targets by [@wojiushixiaobai](https://github.com/wojiushixiaobai) in [#2683](mozilla/sccache#2683) - Add retry for dists docker image build by [@Felixoid](https://github.com/Felixoid) in [#2677](mozilla/sccache#2677) ##### Clippy & cleanup - clippy: fix cloned\_ref\_to\_slice\_refs lint by [@xtqqczze](https://github.com/xtqqczze) in [#2602](mozilla/sccache#2602) - clippy: fix semicolon\_if\_nothing\_returned lint by [@xtqqczze](https://github.com/xtqqczze) in [#2601](mozilla/sccache#2601) - clippy: fix cloned\_instead\_of\_copied lint by [@xtqqczze](https://github.com/xtqqczze) in [#2605](mozilla/sccache#2605) - clippy: fix explicit\_into\_iter\_loop lint by [@xtqqczze](https://github.com/xtqqczze) in [#2616](mozilla/sccache#2616) - clippy: fix unnecessary\_semicolon lint by [@xtqqczze](https://github.com/xtqqczze) in [#2615](mozilla/sccache#2615) - clippy: fix manual\_string\_new lint by [@xtqqczze](https://github.com/xtqqczze) in [#2609](mozilla/sccache#2609) - clippy: fix ptr\_as\_ptr lint by [@xtqqczze](https://github.com/xtqqczze) in [#2611](mozilla/sccache#2611) - clippy: fix ref\_option lint by [@xtqqczze](https://github.com/xtqqczze) in [#2608](mozilla/sccache#2608) - clippy: fix from\_iter\_instead\_of\_collect lint by [@xtqqczze](https://github.com/xtqqczze) in [#2614](mozilla/sccache#2614) - Move PreprocessorCacheModeConfig to src/config.rs by [@xis19](https://github.com/xis19) in [#2604](mozilla/sccache#2604) - Remove benchmark normalize\_win\_path\_utf8 by [@sylvestre](https://github.com/sylvestre) in [#2634](mozilla/sccache#2634) - Move cmake-modules to integration tests by [@Felixoid](https://github.com/Felixoid) in [#2649](mozilla/sccache#2649) ##### Docs - docs(Rust.md): Add caveats from README by [@TheJanzap](https://github.com/TheJanzap) in [#2684](mozilla/sccache#2684) ##### Dependencies - chore: switch thirtyfour\_sync to thirtyfour by [@tottoto](https://github.com/tottoto) in [#2613](mozilla/sccache#2613) - build(deps): bump actions/upload-artifact from 4 to 7 by [@dependabot](https://github.com/dependabot)\[bot] in [#2632](mozilla/sccache#2632) - build(deps): bump actions/download-artifact from 5 to 8 by [@dependabot](https://github.com/dependabot)\[bot] in [#2631](mozilla/sccache#2631) - chore(deps): update rust crate quinn-proto to v0.11.14 by [@xtqqczze](https://github.com/xtqqczze) in [#2645](mozilla/sccache#2645) ##### New Contributors - [@ikolomiko](https://github.com/ikolomiko) made their first contribution in [#2621](mozilla/sccache#2621) - [@JulienCote](https://github.com/JulienCote) made their first contribution in [#2627](mozilla/sccache#2627) - [@msuozzo](https://github.com/msuozzo) made their first contribution in [#2637](mozilla/sccache#2637) - [@weihanglo](https://github.com/weihanglo) made their first contribution in [#2651](mozilla/sccache#2651) - [@wojiushixiaobai](https://github.com/wojiushixiaobai) made their first contribution in [#2669](mozilla/sccache#2669) - [@TheJanzap](https://github.com/TheJanzap) made their first contribution in [#2684](mozilla/sccache#2684) - [@mmastrac](https://github.com/mmastrac) made their first contribution in [#2676](mozilla/sccache#2676) **Full Changelog**: <mozilla/sccache@v0.14.0...v0.15.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/40

chore: switch thirtyfour_sync to thirtyfour

052a22b

thirtyfour_sync crate is not maintained.

tottoto force-pushed the switch-thirtyfour-sync-to-thirtyfour branch from ef2e3cc to 052a22b Compare February 22, 2026 13:51

sylvestre reviewed Feb 22, 2026

View reviewed changes

sylvestre merged commit 81954de into mozilla:main Feb 22, 2026
49 checks passed

tottoto deleted the switch-thirtyfour-sync-to-thirtyfour branch February 22, 2026 17:33

BrewTestBot mentioned this pull request Apr 29, 2026

sccache 0.15.0 Homebrew/homebrew-core#280093

Merged

Navigation Menu

Repository navigation

chore: switch thirtyfour_sync to thirtyfour - #2613

chore: switch thirtyfour_sync to thirtyfour#2613
sylvestre merged 1 commit into
mozilla:mainfrom
tottoto:switch-thirtyfour-sync-to-thirtyfour

tottoto commented Feb 12, 2026

Uh oh!

codecov-commenter commented Feb 12, 2026 •

edited

Loading

Uh oh!

sylvestre commented Feb 21, 2026

Uh oh!

sylvestre Feb 22, 2026

Uh oh!

tottoto Feb 22, 2026

Uh oh!

sylvestre Feb 22, 2026

Uh oh!

tottoto Feb 22, 2026

Uh oh!

sylvestre Feb 22, 2026

Uh oh!

tottoto Feb 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tottoto commented Feb 12, 2026

Uh oh!

codecov-commenter commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sylvestre commented Feb 21, 2026

Uh oh!

sylvestre Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

tottoto Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

tottoto Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

tottoto Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Feb 12, 2026 •

edited

Loading