Add SUMO rules mentions & Improve AAQ step 3#7233
Merged
akatsoulas merged 1 commit intomozilla:mainfrom Feb 5, 2026
Merged
Conversation
Add SUMO rules mentions when creating/editing a question, an answer, a forum thread, a forum post, a KB forum thread or a KB forum post. In AAQ step 3, replace "Subject:" with "Summarize your question" and add help text for this field. In AAQ step 3, display the Troubleshooting Info help text above the Share Data button, right after the field name. In AAQ step 3, add the "tb_version" extra field. In AAQ step 3, autofill the OS version field for Thunderbird. Fix the issue with the Share Data button not working when editing a question. Do not display the Common responses button when editing a question. Improve accessibility. Use "Windows 10/11" when there is not enough info to identify the exact Windows NT 10.0 version. Add l10n comments Improve i18n, internationalize some alt strings Move repeated Helpful Tip code to a macro Remove an unused variable from forms.py
akatsoulas
approved these changes
Feb 5, 2026
| # if you want to use the following string, update it to remove "en-US" from the link first | ||
| # when updating, don't remove the original string, just mark it as deprecated and create a new one | ||
| # L10n: Unused. A description of the "Crash ID(s)" field, displayed when filing a question form (e.g., on https://support.mozilla.org/questions/new/firefox/form). | ||
| CRASH_ID_HELP = _lazy("If you submit information to Mozilla when you crash, you'll be given a crash ID which uniquely identifies your crash and lets us look at details that may help identify the cause. To find your recently submitted crash IDs, go to <strong>about:crashes</strong> in your location bar. <a href='https://support.mozilla.com/en-US/kb/Firefox+crashes#Getting_the_most_accurate_help_with_your_Firefox_crash' target='_blank'>Click for detailed instructions</a>.") |
Collaborator
There was a problem hiding this comment.
We could extract the url into a separate var here to make this easier to read and update if needed.
Contributor
Author
There was a problem hiding this comment.
@akatsoulas I agree, and we also need to remove en-US from the link... But any update of this string will generate a new string for localizers, and since it's currently not in use, we definitely don't want that. I'd say we should put off updating this string until we decide to use it again.
Collaborator
|
@denyshon feel free to follow up if you would like on that review comment in a separate PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #7114, second attempt.
Changes
Resolves #2196, #2536, #1642, #2700.
Screenshots
AAQ step 3 (Firefox): [click to expand]
AAQ step 3 (Firefox) after clicking the Share Data button, in case we failed to pull the data: [click to expand]
AAQ step 3 (Thunderbird): [click to expand]
An example of how the editor looks on the updated surfaces (except for questions): [click to expand]
Note: Some icons in the screenshots may be missing because they were taken on a test setup.
TODO [admin]
Once this PR is merged, the following changes have to be made via the admin console: