Skip to content

Playwright: Fix test failures caused by Monitor #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilghittasv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Playwright: Fix test failures caused by Monitor #6954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion playwright_tests/test_data/aaq_question.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@
"Search, tag, and share": "search-tag-and-share",
"Settings": "settings",
"default_slug": "focus-firefox"
},
"Mozilla Monitor": {
"Passwords and sign in": "passwords-and-sign-in",
"Privacy and security": "privacy-and-security",
"Settings": "settings",
"default_slug": "monitor"
}
}
}
}
6 changes: 3 additions & 3 deletions playwright_tests/test_data/general_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
"Firefox for Enterprise",
"Thunderbird",
"Thunderbird for Android",
"Firefox Focus"
"Firefox Focus",
"Mozilla Monitor"
],
"premium_products": [
"MDN Plus",
"Mozilla VPN",
"Firefox Relay",
"Pocket",
"Mozilla Account",
"Mozilla Monitor"
"Mozilla Account"
],
"kb_article_categories": [
"Troubleshooting",
Expand Down
5 changes: 1 addition & 4 deletions playwright_tests/tests/ask_a_question_tests/aaq_tests/test_aaq_form_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def test_system_details_information(page: Page, create_user_factory):
with allure.step("Navigating to each product aaq form and and adding data without "
"submitting the form"):
for product in utilities.general_test_data["freemium_products"]:
if product == "Thunderbird" or product == "Thunderbird for Android":
if product in ("Thunderbird", "Thunderbird for Android", "Mozilla Monitor"):
continue
else:
utilities.navigate_to_link(
Expand Down Expand Up @@ -453,9 +453,6 @@ def test_system_details_information(page: Page, create_user_factory):
assert sumo_pages.question_page.get_system_details_information(
) == troubleshooting_info

with allure.step("Deleting the posted question"):
sumo_pages.aaq_flow.deleting_question_flow()


# T5696704
@pytest.mark.aaqPage
Expand Down