Skip to content

Sync event databases on persist_ping_lifetime_data #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sync event databases on persist_ping_lifetime_data #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions glean-core/src/core/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,8 @@ impl Glean {
return data.persist_ping_lifetime_data();
}

self.event_storage().sync_event_data();

Ok(())
}

Expand Down
9 changes: 9 additions & 0 deletions glean-core/src/event_database/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,15 @@ impl EventDatabase {
result
}

pub fn sync_event_data(&self) {
let files = self.event_store_files.read().unwrap();
for (name, file) in &*files {
if let Err(e) = file.sync_all() {
log::error!("Failed to sync event data for {name}: {e}");
}
}
}

/// Clears all stored events, both in memory and on-disk.
pub fn clear_all(&self) -> Result<()> {
// safe unwrap, only error case is poisoning
Expand Down