Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enabled locales (add Korean, Thai) #5737

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Update enabled locales (add Korean, Thai) #5737

merged 2 commits into from
Apr 1, 2025

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Mar 29, 2025

I received a message asking why Thai wasn't enabled, turns out the process is manual, and hasn't been checked in forever.

This PR adds Thai (94.8%) and Korean (100%), drops cak (39.76%), nb-NO (38.69%), and ro (36.85%).

@flodolo flodolo requested a review from Vinnl March 29, 2025 13:48
@flodolo
Copy link
Collaborator Author

flodolo commented Mar 29, 2025

Is there more that needs to be done here? Or am I completely off?

Also, could we automate it somehow? This is the script that I created eons ago.

Copy link

@Vinnl
Copy link
Collaborator

Vinnl commented Apr 1, 2025

I'll merge this, but will note for posterity that this only affects local instances - work is in progress to also update the actual environment variables in production.

Edit: variables have also been updated, should take effect at the next deploy (probably tomorrow).

@Vinnl Vinnl merged commit f5ea757 into main Apr 1, 2025
17 checks passed
@Vinnl Vinnl deleted the update_locales branch April 1, 2025 11:50
Copy link

github-actions bot commented Apr 1, 2025

Cleanup completed - database 'blurts-server-pr-5737' destroyed, cloud run service 'blurts-server-pr-5737' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants