Skip to content

Conversation

@kwindau
Copy link
Contributor

@kwindau kwindau commented Nov 22, 2025

Description

This PR is a follow-up fix to PR-8492, which had a string formatting issue.

Related Tickets & Documents

Reviewer, please follow this checklist

@kwindau kwindau force-pushed the market-intel-bot-tweaks branch from 8d2372c to 1041d84 Compare November 22, 2025 03:52
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@kwindau kwindau marked this pull request as ready for review November 24, 2025 13:32
@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into market-intel-bot-tweaks"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/external_derived/market_intel_bot_v1/query.py /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/external_derived/market_intel_bot_v1/query.py
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/external_derived/market_intel_bot_v1/query.py	2025-11-24 13:38:11.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/external_derived/market_intel_bot_v1/query.py	2025-11-24 13:33:27.000000000 +0000
@@ -236,8 +236,9 @@
     # Prompt #1 - New Features in Popular Browsers
     prompt1 = (
         "Look for articles about what new features have been added to popular web browsers, "
-        "and how popular browsers are incorporating AI. " + news_range_of_interest
-        "Then summarize these findings."
+        "and how popular browsers are incorporating AI. "
+        f"{news_range_of_interest} "
+        "Then summarize these findings. "
         "Firefox should be omitted from this search as we are focusing on Firefox's competitors."
     )
     final_output_1, response_object_1 = summarize_with_open_ai(
@@ -294,10 +295,13 @@
 More details can be found here: [Chrome Dev Tools](https://developer.chrome.com/docs/devtools/news?hl=en#whats-new)"""
 
     # Prompt #5 - Browser & Device Partnership News
-    prompt5 = """Please find articles related to browser & device partnerships.
+    prompt5 = (
+        """Please find articles related to browser & device partnerships.
 Firefox should be omitted from this search as we are focusing on Firefox's competitors.
 Please find all recent announcements of browser-device partnerships with browsers like Chrome, Edge, Safari, etc. and
-devices like mobile phones, Smart TVs, or VR (virtual reality), then summarize these findings.""" + news_range_of_interest
+devices like mobile phones, Smart TVs, or VR (virtual reality), then summarize these findings."""
+        + news_range_of_interest
+    )
     final_output_5, response_object_5 = summarize_with_open_ai(
         client,
         MODEL_TYPE,
@@ -310,7 +314,10 @@
     final_report += f"\n{final_output_5}\n\n"
 
     # Prompt #6 - Online Advertising News
-    prompt6 = "Look for articles from the past month about news related to online advertising, and summarize the findings."
+    prompt6 = (
+        "Look for articles about news related to online advertising, and summarize the findings."
+        + news_range_of_interest
+    )
     final_output_6, response_object_6 = summarize_with_open_ai(
         client,
         MODEL_TYPE,
@@ -324,7 +331,8 @@
 
     # Prompt #7 - AI News
     prompt7 = (
-        "Look for articles about news related to AI in general." + news_range_of_interest
+        "Look for articles about news related to AI in general."
+        + news_range_of_interest
     )
     final_output_7, response_object_7 = summarize_with_open_ai(
         client,

Link to full diff

@kwindau kwindau added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit a7bb763 Nov 24, 2025
22 checks passed
@kwindau kwindau deleted the market-intel-bot-tweaks branch November 24, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants