Bug 1905714 - Only match JS::Call exactly in signatures. #6652
Conversation
There was a problem hiding this comment.
The regexp looks correct.
Verifying this is a little trickier, since it's building off of your earlier patch late last week, which isn't yet in prod.
I chose one of the crash IDs from the previous PR, 0ba5c8d8-e0eb-4777-9669-5e94f0240622, and I looked at its crash signature on main relative to its signature on this feature branch (via socorro-cmd signature 0ba5c8d8-e0eb-4777-9669-5e94f0240622) -- does this look like what you wanted @amccreight ?
main(i.e. Old):"OOM | unknown | js::AutoEnterOOMUnsafeRegion::crash_impl | JS::CallbackTracer::onEdge | js::GenericTracerImpl<T>::onObjectEdge"- This branch (i.e. New):
"OOM | unknown | js::AutoEnterOOMUnsafeRegion::crash_impl | JS::CallbackTracer::onEdge"
Edit: This looks to be the same as what is in prod now for this crash ID. 🤔
|
Yes, that's right. Thanks. I didn't mean to change the signature for this crash with my change. Here's an example of a crash report that should end up with JS::Call in the crash signature with both patches: https://crash-stats.mozilla.org/report/index/54664941-776c-4107-8a03-164a80240617 |
|
@amccreight , willkg tried to do a prod deploy for Socorro just now (bug-1906174), but the deployment didn't kick off as expected. We just migrated to GCP, so we may still need to iron out some kinks. Hopefully relud (the lead engineer on the GCP migration effort) can take a look when they return next week. That's tracked in obs-264. |
|
Update: 2024-07-08 - the deploy issue was fixed, and Socorro was successfully deployed to prod: https://bugzilla.mozilla.org/show_bug.cgi?id=1906174#c3 . |
This improves the update_siggen.py to include the authors of commits at the end of the commit summary line. We should be giving credit where credit is due. This information shows up in the merge commits in siggen as well as the HISTORY file and tag annotation. Before: ``` Dest sha: 2edf215 Source sha: bd98591 fd9a519 Bug 1907894 - Add mozilla::Atomic<T> to the irrelevant signature list. f51eb33 Bug 1906667 - Add mozilla::media::Interval<T> to the prefix list. (#6663) e1d2b1a Bug 1905714 - Only match JS::Call exactly in signatures. (#6652) 8cf6cf3 bug-1904528: add SafeVariantClear and VariantCopy to prefix list ``` After: ``` Dest sha: 2edf215 Source sha: bd98591 fd9a519 Bug 1907894 - Add mozilla::Atomic<T> to the irrelevant signature list. (Andrew McCreight) f51eb33 Bug 1906667 - Add mozilla::media::Interval<T> to the prefix list. (#6663) (Andrew McCreight) e1d2b1a Bug 1905714 - Only match JS::Call exactly in signatures. (#6652) (Andrew McCreight) 8cf6cf3 bug-1904528: add SafeVariantClear and VariantCopy to prefix list (Will Kahn-Greene) ```
This improves the update_siggen.py to include the authors of commits at the end of the commit summary line. We should be giving credit where credit is due. This information shows up in the merge commits in siggen as well as the HISTORY file and tag annotation. Before: ``` Dest sha: 2edf215 Source sha: bd98591 fd9a519 Bug 1907894 - Add mozilla::Atomic<T> to the irrelevant signature list. f51eb33 Bug 1906667 - Add mozilla::media::Interval<T> to the prefix list. (#6663) e1d2b1a Bug 1905714 - Only match JS::Call exactly in signatures. (#6652) 8cf6cf3 bug-1904528: add SafeVariantClear and VariantCopy to prefix list ``` After: ``` Dest sha: 2edf215 Source sha: bd98591 fd9a519 Bug 1907894 - Add mozilla::Atomic<T> to the irrelevant signature list. (Andrew McCreight) f51eb33 Bug 1906667 - Add mozilla::media::Interval<T> to the prefix list. (#6663) (Andrew McCreight) e1d2b1a Bug 1905714 - Only match JS::Call exactly in signatures. (#6652) (Andrew McCreight) 8cf6cf3 bug-1904528: add SafeVariantClear and VariantCopy to prefix list (Will Kahn-Greene) ```
No description provided.