Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version property is required when present in legacy telemetry #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sean-rose
Copy link
Contributor

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

Copy link
Contributor

@BenWu BenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary because the decoder drops these pings before they get to schema validation but it also doesn't hurt to be more explicit in the schema. I don't have a problem with this especially if it's needed for the other PR but it'd be good to have @akkomar to review

@sean-rose
Copy link
Contributor Author

especially if it's needed for the other PR

It isn't needed for #811 as I've already made adjustments there to more gracefully handle version properties that might be configured to allow nulls (though that should never be the case in the actual data due to how ingestion works as you've pointed out).

So this is more about making the affected schemas more reflective of reality, consistent with the other legacy schemas, and enforcing that consistency for legacy schemas going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants