APP-314 fix. Workflow now highlights asserts, presses, text fields etc as intended#273
APP-314 fix. Workflow now highlights asserts, presses, text fields etc as intended#273chinmayajha wants to merge 1 commit intomozarkai:mainfrom
Conversation
|
thakur-patel
left a comment
thakur-patel
left a comment
There was a problem hiding this comment.
Where is the change to highlight elements? I only see a timestamp filename change done in this PR
| current_time_in_desired_timezone = current_utc_time.astimezone(desired_timezone) | ||
| formatted_time = current_time_in_desired_timezone.strftime("%Y-%m-%dT%H:%M:%S.%f%z") | ||
| return formatted_time[:-2] + ":" + formatted_time[-2:] | ||
| ist = timezone(timedelta(hours=5, minutes=30)) |
There was a problem hiding this comment.
do not hardcode timezones
| internal_logger.debug(f"Screenshot saved as : {time_stamp}-{name}.jpg") | ||
| internal_logger.debug(f"Screenshot saved to :{screenshot_file_path}") | ||
| else: | ||
| internal_logger.error(f"cv2 returned FALSE. FAILED to save screenshot to : {screenshot_file_path}") |
There was a problem hiding this comment.
this error will not give context to a developer new to this repo, we can improve it
The highlights were already being handled. Issue was the filename (which had the timstamp) being invalid, thus the screenshot not getting saved. I just made the function a bit better.
Noted. will commit another change.
OKay, I'll see what I can do |
2 participants
Fix to https://mozarkai-orchestrator.atlassian.net/browse/APP-314
Workflow already handled annotations, but the problem was in saving of the image. Commit fixes invalid timestamp format causing screenshot save failure (on windows)
changes file saving behaviour, fixes workflow