feat(appium): improve deeplink handling with Android ADB fallback and…#262
Open
sheshnath1st wants to merge 3 commits intomozarkai:mainfrom
Open
feat(appium): improve deeplink handling with Android ADB fallback and…#262sheshnath1st wants to merge 3 commits intomozarkai:mainfrom
sheshnath1st wants to merge 3 commits intomozarkai:mainfrom
Conversation
… iOS Safari support
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances deep link launching in the Appium driver by improving URL detection, normalizing platform handling, adding an Android ADB fallback path, and switching iOS deep link launching toward mobile: openUrl with a Safari fallback.
Changes:
- Tighten deep link detection by stripping whitespace before checking for
://. - Normalize
platformNameto lowercase and expand Android deep link handling to includepackageplus an ADB fallback. - Update iOS deep link launching to use
mobile: openUrlwith a Safari fallback attempt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… Android ADB fallback, and iOS openUrl support
|
thakur-patel
requested changes
Mar 9, 2026
|
|
||
| driver.get(deeplink) | ||
| except Exception as exc: | ||
| internal_logger.debug(f"mobile:openUrl failed: {exc}") |
Contributor
There was a problem hiding this comment.
why is this a debug log
| if package: | ||
| payload["package"] = package | ||
| driver.execute_script("mobile: deepLink", payload) | ||
| internal_logger.debug( |
Contributor
There was a problem hiding this comment.
this should be added to the end of the function, like in ios deep link implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… iOS Safari support