Skip to content

Fix live logs to display raw parameters instead of resolved values #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix live logs to display raw parameters instead of resolved values #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d6280
Initial plan
Copilot Jul 2, 2025
37177b5
Implement raw parameters display in live logs to fix issue #85
Copilot Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions optics_framework/common/runner/test_runnner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ def _initialize_test_state(self) -> None:
name=current_module.name, elapsed="0.00s", status="NOT_RUN", keywords=[])
current_keyword = current_module.keywords_head
while current_keyword:
resolved_params = [self.resolve_param(
param) for param in current_keyword.params]
resolved_name = f"{current_keyword.name} ({', '.join(str(p) for p in resolved_params)})" if resolved_params else current_keyword.name
# Use raw parameters for display instead of resolved ones
raw_params = current_keyword.params
resolved_name = f"{current_keyword.name} ({', '.join(str(p) for p in raw_params)})" if raw_params else current_keyword.name
keyword_result = KeywordResult(
id=current_keyword.id,
name=current_keyword.name,
Expand Down Expand Up @@ -276,10 +276,9 @@ async def _execute_keyword(
value = self.resolve_param(value)
resolved_kw_params[key] = value
if isinstance(keyword_result, KeywordResult):
positional_str = ", ".join(str(p) for p in resolved_positional_params)
keyword_str = ", ".join(f"{k}={v}" for k, v in resolved_kw_params.items())
combined_params = ", ".join(filter(None, [positional_str, keyword_str]))
keyword_result.resolved_name = f"{keyword_node.name} ({combined_params})" if combined_params else keyword_node.name
# Use raw parameters for display instead of resolved ones
raw_params = keyword_node.params
keyword_result.resolved_name = f"{keyword_node.name} ({', '.join(str(p) for p in raw_params)})" if raw_params else keyword_node.name
positional_str = ", ".join(str(p) for p in resolved_positional_params)
keyword_str = ", ".join(f"{k}={v}" for k, v in resolved_kw_params.items())
combined_params_str = ", ".join(filter(None, [positional_str, keyword_str]))
Expand Down Expand Up @@ -426,9 +425,10 @@ async def _dry_run_module(self, module_node: ModuleNode, test_case_result: TestC
self._update_status(keyword_result, "RUNNING", 0.0, test_case_result.name)

try:
resolved_params = [self.resolve_param(param) for param in keyword_current.params]
if isinstance(keyword_result, KeywordResult):
keyword_result.resolved_name = f"{keyword_current.name} ({', '.join(resolved_params)})" if resolved_params else keyword_current.name
# Use raw parameters for display instead of resolved ones
raw_params = keyword_current.params
keyword_result.resolved_name = f"{keyword_current.name} ({', '.join(str(p) for p in raw_params)})" if raw_params else keyword_current.name
func_name = "_".join(keyword_current.name.split()).lower()
if func_name not in self.keyword_map:
raise ValueError("Keyword not found")
Expand Down