movement branch #115
Open
movement branch #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Framework Move modules and spec for Trusted Relayer Native Bridge
…th side. Move unit tests pass, still working on E2E Move tests
…he expected bridge transfer ID
…for now to help reviewers make sense of everything
Native bridge: Modify param serialization to make bridge transfer IDs match on Move and Solidity sides in both L1 -> L2 and L2 -> L1 directions
Add Bridge Fee to Move Bridge Module
…ce-false feat: make is_core_resource_address always return false
…e from default features
…o default features (with exception of PERIODICAL_REWARD_RATE_DECREASE)
…o default features (with exception of PERIODICAL_REWARD_RATE_DECREASE)
…theus with grafana
Co-authored-by: Andy Golay <[email protected]>
Co-authored-by: Andy Golay <[email protected]>
…lags feat: Include Aptos feature flags required for pre-l1-merge framework…
Updated metrics with prometheus and grafana setup
feat: annotate some functions in `object.move` as `#[view]`
## Description <!-- Please include a summary of the change, including which issue it fixes or what feature it adds. Include relevant motivation, context and documentation as appropriate. List dependencies that are required for this change, if any. --> ## Type of Change - [ ] New feature - [ ] Bug fix - [ ] Breaking change - [ ] Performance improvement - [ ] Refactoring - [ ] Dependency update - [ ] Documentation update - [ ] Tests ## Which Components or Systems Does This Change Impact? - [ ] Validator Node - [ ] Full Node (API, Indexer, etc.) - [ ] Move/Aptos Virtual Machine - [ ] Aptos Framework - [ ] Aptos CLI/SDK - [ ] Developer Infrastructure - [ ] Other (specify) ## How Has This Been Tested? <!-- - Please ensure that the functionality introduced by this change is well tested and verified to work as expected. - Ensure tests cover both happy and unhappy paths. - List and link relevant tests. --> ## Key Areas to Review <!-- - Identify any critical parts of the code that require special attention or understanding. Explain why these parts are crucial to the functionality or architecture of the project. - Point out any areas where complex logic has been implemented. Provide a brief explanation of the logic and your approach to make it easier for reviewers to follow. - Highlight any areas where you are particularly concerned or unsure about the code's impact on the change. This can include potential performance or security issues, or compatibility with existing features. --> ## Checklist - [ ] I have read and followed the [CONTRIBUTING](https://github.com/aptos-labs/aptos-core/blob/main/CONTRIBUTING.md) doc - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I identified and added all stakeholders and component owners affected by this change as reviewers - [ ] I tested both happy and unhappy path of the functionality - [ ] I have made corresponding changes to the documentation <!-- Thank you for your contribution! -->
This was cherry picked from `0ae9d6f8721954e7428a9feefac83ae52bff0355` on `movement-migration` which is the squash commit from PR #227. We need this commits now on `movement` for testing purposes. --------- Co-authored-by: Bo Wu <[email protected]> Co-authored-by: musitdev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist