Fix Abstraction signature parser swapping signer and type - #45
Open
sausagee wants to merge 3 commits into
Open
Conversation
parse_abstraction_signature listed sender before account_signature_type while from_account_signature (and every other parse_* helper) passed type then sender. Abstraction rows therefore stored the type string as signer and the sender address as account_signature_type. Movement mainnet ships 0x1::account_abstraction, so this path is live. Co-authored-by: Young Yang Liauw <sausagee@users.noreply.github.com>
SDK v2.1.1 exports AbstractionSignature, not AbstractSignature. Co-authored-by: Young Yang Liauw <sausagee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
from_account_signaturecallsparse_abstraction_signature(&account_signature_type, sender, ...), matching every otherparse_*helper (type string first, then sender). The function was defined as(sender, account_signature_type, ...).Rust accepts the call because
&Stringcoerces to&str, so this compiled. Abstraction rows then stored:signer=standardize_address("abstraction_signature")(garbage / non-address)account_signature_type= the real sender addressMovement mainnet publishes
0x1::account_abstraction(plusethereum_derivable_account/solana_derivable_account), so this path is live production code.Not covered by open PRs #16–#44 (MultiKey pubkey index is #44; fee-payer is #43).
Root cause
Parameter order on the stub parser did not match the call site or the other signature parsers.
Fix
Reorder
parse_abstraction_signatureto(account_signature_type, sender, ...). Stub still writes"Not implemented"for pubkey/signature bytes; this PR only fixes the swapped fields.Tests run (rustc 1.85.0)
cargo test -p processor --lib from_account_signature_abstraction— 2 passedcargo test -p processor --lib— 26 passed; 18 failed only on missing Docker/GCS (processor_status_saver / parquet buffer), unrelatedcargo clippy -p processor --lib --tests -- -D warnings— cleanOut of scope (checked, not filed)
domainsvsv2_1_domains: intentional Movement nameservice change (2fad999), not fixture drift on Movement.public_key_indices.