feat: [HL-80] Meal details by id API 🍔 #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahattalla
changed the title
Ahattalla
changed the title
ahmdmhasn
reviewed
Jul 25, 2023
Comment on lines
+10
to
+11
| var ingredients: [String] = [] | ||
| var measures: [String] = [] |
Contributor
There was a problem hiding this comment.
Suggested change
| var ingredients: [String] = [] | |
| var measures: [String] = [] | |
| let ingredients: [String] = [] | |
| let measures: [String] = [] |
|
|
||
| // MARK: - Meal Details | ||
| public struct MealDetails: Decodable { | ||
| let id, name, drinkAlternate, category, area, instructions, thumbnail, tags: String? |
Contributor
There was a problem hiding this comment.
Id should never be optional
| @@ -0,0 +1,57 @@ | |||
| // MARK: - MealDetailsResponse | |||
| public struct MealDetailsResponse: Decodable { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| public struct MealDetailsResponse: Decodable { | |
| struct MealDetailsResponse: Decodable { |
No need to make this public, just return a list of meals.
| var ingredients: [String] = [] | ||
| var measures: [String] = [] | ||
|
|
||
| enum CodingKeys: String, CodingKey { |
Contributor
There was a problem hiding this comment.
Suggested change
| enum CodingKeys: String, CodingKey { | |
| private enum CodingKeys: String, CodingKey { |
| .compactMap { $0.isEmpty ? nil : $0} | ||
| } | ||
|
|
||
| private func dynamicValuesFor(dynamicKey: String, with decoder: Decoder) throws -> [String] { |
Contributor
There was a problem hiding this comment.
Thanks for adding this. A good practice when adding a code that the others in the might might not be aware of is to write comments. Documentation helps your future self understand why ou added this in the first place.
| @@ -0,0 +1,12 @@ | |||
| struct DynamicCodingKeys: CodingKey { | |||
Contributor
There was a problem hiding this comment.
Thanks for adding it, I like the idea 🙏🏼
Comment on lines
+2
to
+11
| var intValue: Int? | ||
| init?(intValue: Int) { | ||
| self.intValue = intValue | ||
| self.stringValue = "\(intValue)" | ||
| } | ||
|
|
||
| var stringValue: String | ||
| init(stringValue: String) { | ||
| self.stringValue = stringValue | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| var intValue: Int? | |
| init?(intValue: Int) { | |
| self.intValue = intValue | |
| self.stringValue = "\(intValue)" | |
| } | |
| var stringValue: String | |
| init(stringValue: String) { | |
| self.stringValue = stringValue | |
| } | |
| let intValue: Int? | |
| init?(intValue: Int) { | |
| self.intValue = intValue | |
| self.stringValue = "\(intValue)" | |
| } | |
| let stringValue: String | |
| init(stringValue: String) { | |
| self.stringValue = stringValue | |
| } |
To avoid duplication, you might consider making it generic, or at least have two versions for both Int and String.
Comment on lines
+4
to
+5
| var ingredients: [String] = [] | ||
| var measures: [String] = [] |
Contributor
There was a problem hiding this comment.
Suggested change
| var ingredients: [String] = [] | |
| var measures: [String] = [] | |
| let ingredients: [String] = [] | |
| let measures: [String] = [] |
Mutability is a big source of bugs. Avoid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Created Meal details API request
Related Issues
List any related issues or pull requests.
N/A
Additional Information
N/A
Screenshot
N/A
Checklist