feat: [HL-87] Registration <> Handle and integrate registration use case. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mock Data for LoginUseCase until Actual Request is finished
ahmednasr8898
requested review from
a team,
ahmdmhasn,
ahmdyasser and
mhmdatallaa
ahmdmhasn
approved these changes
Jul 26, 2023
| func bindLoadingIndicator() { | ||
| viewModel.loadingIndicatorPublisher | ||
| .sink { _ in | ||
| // TODO: Show loading indicator. |
Contributor
There was a problem hiding this comment.
Let's show it using the loading on the button
| import Domain | ||
| import Networking | ||
|
|
||
| extension Container { |
Contributor
There was a problem hiding this comment.
Let's add it to another file in the same folder
Contributor
Author
There was a problem hiding this comment.
can you more explain about this comment ? @ahmdmhasn
Comment on lines
23
to
24
| return User(email: response.email, tokenID: response.tokenId) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| return User(email: response.email, tokenID: response.tokenId) | |
| return User(email: response.email, tokenID: response.tokenId) |
Base automatically changed from
feat/handle-and-integrate-login-use-case
to
develop
August 4, 2023 09:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Issues
N/A.
Additional Information
N/A.
Screenshot
N/A.
Checklist