Bad examples now have flake8 errors, pin those to prevent failing

mothicompbo · Jul 13, 2019 · 46076b6 · 46076b6
1 parent eb1f3f3
commit 46076b6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -39,8 +39,11 @@ venv2/
 # Sphinx documentation
 docs/_build/
 
-# isort
-/isort.out
-
 # mypy
 .mypy_cache/
+
+# --- CUSTOM ---
+
+# temp outputs for isort and flake8
+/isort.out
+/flake8.out
diff --git a/Makefile b/Makefile
@@ -53,7 +53,8 @@ fixlint:
 .PHONY: lintexamples
 lintexamples:
 	@echo "=== flake8 ==="
-	flake8 examples
+	flake8 examples | sort > flake8.out
+	diff examples/bad/flake8_expected.out flake8.out
 	@echo "=== black ==="
 	black --check --diff --verbose examples/good/black
 

diff --git a/examples/bad/flake8_expected.out b/examples/bad/flake8_expected.out
@@ -0,0 +1,2 @@
+examples/bad/test_noqa_flake8.py:11:17: E225 missing whitespace around operator
+examples/bad/test_noqa_flake8.py:5:10: E201 whitespace after '('
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		examples/bad/test_noqa_flake8.py:11:17: E225 missing whitespace around operator
		examples/bad/test_noqa_flake8.py:5:10: E201 whitespace after '('