Skip to content

fix: allow unsetting of connector endpoint url #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mplatzer merged 1 commit into from
Jun 11, 2025
Merged

fix: allow unsetting of connector endpoint url #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mostlyai/sdk/_data/file/container/aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def __init__(
**kwargs,
):
super().__init__(*args, **kwargs)
self.endpoint_url = endpoint_url
self.endpoint_url = endpoint_url or None
self.access_key = access_key
self.secret_key = secret_key
# SSL
Expand Down Expand Up @@ -93,7 +93,7 @@ def __init__(
key=self.access_key,
client_kwargs=client_kwargs,
)
self._boto_resource = boto_session.resource("s3", endpoint_url=endpoint_url, verify=self.ssl_verify)
self._boto_resource = boto_session.resource("s3", endpoint_url=self.endpoint_url, verify=self.ssl_verify)
self._boto_client = boto_session.client("s3", endpoint_url=self.endpoint_url, verify=self.ssl_verify)
# patch CloudPath to use the same boto3 resource/client
self._client.s3 = self._boto_resource
Expand Down